Skip to content

initial implementation of Bundled Plugins #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnny-hausman merged 2 commits into from
Jan 31, 2026
Merged

initial implementation of Bundled Plugins #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8311121
[wip] initial implementation of Bundled Plugins
johnny-hausman Jan 29, 2026
389fa77
[wip] refactor pluginLocalLoad() to be in ABFactory.init()
johnny-hausman Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ABFactoryCore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,10 +279,11 @@ class ABFactory extends EventEmitter {
}
}

init() {
async init() {
// BEFORE Definitions are loaded,
// make sure any local Plugins are loaded.
this.ClassManager.registerLocalPlugins(this.pluginAPI());
// this.ClassManager.registerLocalPlugins(this.pluginAPI());
await this.pluginLocalLoad();

let allDefinitions = Object.keys(this._definitions).map(
(k) => this._definitions[k]
Expand Down Expand Up @@ -777,6 +778,13 @@ class ABFactory extends EventEmitter {
return api;
}

pluginLocalLoad() {
// This is a placeholder for a local plugin load.
// The platform version of this method will load the plugins from
// /platform/plugins/local/
return Promise.resolve();
}

pluginRegister(plugin) {
let pluginClass = plugin(this.pluginAPI());
if (Array.isArray(pluginClass)) {
Expand Down
4 changes: 2 additions & 2 deletions ABViewManagerCore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ var AllViews = [
require("../platform/views/ABViewImage"),
require("../platform/views/ABViewLabel"),
require("../platform/views/ABViewLayout"),
require("../platform/views/ABViewList"),
// require("../platform/views/ABViewList"),
require("../platform/views/ABViewMenu"),
require("../platform/views/ABViewPage"),
require("../platform/views/ABViewPDFImporter"),
require("../platform/views/ABViewPivot"),
require("../platform/views/ABViewTab"),
// require("../platform/views/ABViewTab"),
require("../platform/views/ABViewText"),

//
Expand Down
Loading