Skip to content

Conversation

@nh758
Copy link
Contributor

@nh758 nh758 commented Sep 10, 2025

I made these 3 changes to get api_sails running in ecs.

1- Removed the checks for DB before sails lifts

Initially I did this just to test if we get the ECS deploy working without setting up the database first. But it got me thinking, do we even need this connections, since now the services interact with the db? I don’t think we need it for sails, but I’m not confident.

📝 Note: If we want to remove the db requirement should update the Docker CMD to [“node”, “app.js”] (instead of the wait mysql file)

2- I modified resolving appbuilder-stage prefix as the admin tenant

This might not be needed, but we may need a more robust way to map the incoming hostname to a tenant. Joshua had an idea here: #41

Or add a way to configure this via ENV?

3- Removed direct calls to web

As part of getting the current versions we made calls to http://web:80. I don't know exactly why we need this but it won't work in ecs. At least would need to make this configurable.

@github-actions
Copy link
Contributor

Please add one release label:
major (for breaking changes), minor (for new features), patch (for bug fixes) or skip-release (to skip the auto release process).

@nh758 nh758 changed the title Remove the db required to lift ECS Chnages Sep 12, 2025
@nh758 nh758 changed the title ECS Chnages ECS Changes Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants