Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made these 3 changes to get
api_sailsrunning inecs.1- Removed the checks for DB before sails lifts
Initially I did this just to test if we get the ECS deploy working without setting up the database first. But it got me thinking, do we even need this connections, since now the services interact with the db? I don’t think we need it for sails, but I’m not confident.
📝 Note: If we want to remove the db requirement should update the Docker CMD to
[“node”, “app.js”](instead of the wait mysql file)2- I modified resolving
appbuilder-stageprefix as theadmintenantThis might not be needed, but we may need a more robust way to map the incoming hostname to a tenant. Joshua had an idea here: #41
Or add a way to configure this via ENV?
3- Removed direct calls to
webAs part of getting the current versions we made calls to
http://web:80. I don't know exactly why we need this but it won't work inecs. At least would need to make this configurable.