Migrate BE component / sidebar item translation keys to FE #8172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adi-herwana-nus
force-pushed
the
adi/move-sidebar-translations
branch
4 times, most recently
from
7698e80 to
8a944f2
Compare
adi-herwana-nus
force-pushed
the
adi/move-sidebar-translations
branch
5 times, most recently
from
260cc1e to
090bc17
Compare
- reorganized client/app/bundles/course/translations.intl.js, added missing keys and converted to TS - modified BE component / sidebar item routes to no longer return default titles - modified FE to fetch default title if none or blank title received from BE
…lation keys - removed BE title references in Timeline Designer - removed BE title references in Lesson Plan view - removed BE title references in Materials view & file download
adi-herwana-nus
force-pushed
the
adi/move-sidebar-translations
branch
from
090bc17 to
349cfdc
Compare
adi-herwana-nus
force-pushed
the
adi/move-sidebar-translations
branch
from
349cfdc to
65e4f35
Compare
adi-herwana-nus
force-pushed
the
adi/move-sidebar-translations
branch
from
65e4f35 to
aeba729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the various translation keys associated with components / sidebar items from Rails BE to React FE.
For certain components (e.g. assessments), user is able to specify custom titles for the sidebar items. This behavior is unchanged, and any set custom titles will still be returned from BE and rendered by FE.