Conversation
csm-thu
requested changes
Oct 14, 2025
Member
csm-thu
left a comment
csm-thu
left a comment
There was a problem hiding this comment.
Requested some changes 🙂
By the way, the unit tests in the repo are broken on your branch (you can run them by launching yarn test)
Also, do you think it would be possible to split your work on this ticket in two commits? One for the columns metadata not being built on every iteration of the loop, and another commit for the change or tweak of date parsing function. This way, if we don't find a better mechanism for the second part, the first part remains ready to be used (it also has less risks to break something ^^)
nborde-CSM
approved these changes
Oct 14, 2025
Contributor
nborde-CSM
left a comment
nborde-CSM
left a comment
There was a problem hiding this comment.
A little typo on the commit message : imporve instead of improve
Some remarks but in overall LGTM 👍
arianber7
changed the title
arianber7
force-pushed
the
abe/Improve-perfs-of-CSV-parsing-for-Table-components-PROD-10196
branch
4 times, most recently
from
8f3435c to
630ca95
Compare
csm-thu
requested changes
Oct 22, 2025
arianber7
force-pushed
the
abe/Improve-perfs-of-CSV-parsing-for-Table-components-PROD-10196
branch
from
787f0ff to
742cd4b
Compare
csm-thu
force-pushed
the
abe/Improve-perfs-of-CSV-parsing-for-Table-components-PROD-10196
branch
from
742cd4b to
7684cf3
Compare
csm-thu
force-pushed
the
abe/Improve-perfs-of-CSV-parsing-for-Table-components-PROD-10196
branch
from
7684cf3 to
ba94fae
Compare
csm-thu
deleted the
abe/Improve-perfs-of-CSV-parsing-for-Table-components-PROD-10196
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.