Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ class ControllerTestUtils {
tags: MutableList<String> = mutableListOf(),
datasetList: MutableList<String>? = mutableListOf(),
parametersValues: MutableList<RunnerRunTemplateParameterValue>? = mutableListOf(),
validationStatus: RunnerValidationStatus,
): RunnerUpdateRequest {

return RunnerUpdateRequest(
Expand All @@ -233,6 +234,7 @@ class ControllerTestUtils {
additionalData = additionalData,
solutionName = solutionName,
runTemplateName = runTemplateName,
validationStatus = validationStatus,
)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,7 @@ class RunnerControllerTests : ControllerTestBase() {
val datasetList = mutableListOf(datasetId)
val runnerParameterValue = "parameter_value"
val runnerParameterVarType = "this_is_a_vartype"
val validationStatus = RunnerValidationStatus.Validated

val additionalData =
mutableMapOf(
Expand Down Expand Up @@ -521,6 +522,7 @@ class RunnerControllerTests : ControllerTestBase() {
isInherited = false,
)
),
validationStatus = validationStatus,
)

mvc.perform(
Expand Down Expand Up @@ -555,6 +557,7 @@ class RunnerControllerTests : ControllerTestBase() {
.andExpect(jsonPath("$.parametersValues[0].value").value(runnerParameterValue))
.andExpect(jsonPath("$.parametersValues[0].varType").value(solutionParameterVarType1))
.andExpect(jsonPath("$.parametersValues[0].isInherited").value(false))
.andExpect(jsonPath("$.validationStatus").value(validationStatus.name))
.andExpect(jsonPath("$.security.accessControlList[0].role").value(ROLE_ADMIN))
.andExpect(jsonPath("$.security.accessControlList[0].id").value(PLATFORM_ADMIN_EMAIL))
.andDo(MockMvcResultHandlers.print())
Expand Down
1 change: 1 addition & 0 deletions doc/Models/RunnerUpdateRequest.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
| **additionalData** | [**Map**](AnyType.md) | Free form additional data | [optional] [default to null] |
| **solutionName** | **String** | the Solution name | [optional] [default to null] |
| **runTemplateName** | **String** | the Solution Run Template name associated with this Runner | [optional] [default to null] |
| **validationStatus** | [**RunnerValidationStatus**](RunnerValidationStatus.md) | | [optional] [default to null] |

[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)

1 change: 1 addition & 0 deletions openapi/plantuml/schemas.plantuml
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,7 @@ entity RunnerUpdateRequest {
additionalData: Map
solutionName: String
runTemplateName: String
validationStatus: RunnerValidationStatus
}

entity RunnerValidationStatus {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,30 @@ class RunnerServiceIntegrationTest : CsmTestBase() {
)
}

@Test
fun `test updateRunner with validationStatus`() {
assertEquals(RunnerValidationStatus.Draft, runnerSaved.validationStatus)

val updateRunnerResponse =
runnerApiService.updateRunner(
organizationSaved.id,
workspaceSaved.id,
runnerSaved.id,
RunnerUpdateRequest(
validationStatus = RunnerValidationStatus.Validated,
),
)
assertEquals(RunnerValidationStatus.Validated, updateRunnerResponse.validationStatus)

val updatedRunner =
runnerApiService.getRunner(
organizationSaved.id,
workspaceSaved.id,
runnerSaved.id,
)
assertEquals(RunnerValidationStatus.Validated, updatedRunner.validationStatus)
}

@Test
fun `test updateRunner and check parameterValues after updating a simple solution parameter to DATASET_PART varType`() {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,7 @@ class RunnerService(
)
}

@Suppress("LongMethod")
fun setValueFrom(runnerUpdateRequest: RunnerUpdateRequest): RunnerInstance {

runnerUpdateRequest.runSizing?.let {
Expand Down Expand Up @@ -515,7 +516,8 @@ class RunnerService(
lastRunStatus = this.runner.lastRunInfo.lastRunStatus,
lastRunId = this.runner.lastRunInfo.lastRunId,
),
validationStatus = this.runner.validationStatus,
validationStatus =
runnerUpdateRequest.validationStatus ?: this.runner.validationStatus,
)
)
}
Expand Down
3 changes: 3 additions & 0 deletions runner/src/main/openapi/runner.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -774,6 +774,9 @@ components:
description: the Solution Run Template name associated with this Runner
minLength: 1
x-size-message: "cannot be empty"
validationStatus:
allOf:
- $ref: '#/components/schemas/RunnerValidationStatus'
RunnerSecurity:
type: object
description: the Runner security information
Expand Down