fix: fix Azure Byok #696
Closed
fix: fix Azure Byok #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HatemMn
commented
Jan 29, 2026
| const kidTag = tags.find((t: string) => t.startsWith("kid:")); | ||
| if (!kidTag) { | ||
| setRes( | ||
| "The KEK is not an Azure Key Encryption Key: Azure kid not found. Import it using the Import KEK command." |
Contributor
Author
There was a problem hiding this comment.
normal users don't need details
| import { useAuth } from "./AuthContext"; | ||
| import { downloadFile, sendKmipRequest } from "./utils"; | ||
| import { AZURE_BYOK_TAG } from "./AzureImportKek"; | ||
| import * as wasm from "./wasm/pkg"; |
Contributor
Author
There was a problem hiding this comment.
this was done in pupose (like many other files on the repo) as it has 0 effect of the final compiled code but makes it way more evident for someone who debugs to find wasm functions
| } | ||
| }, [res]); | ||
|
|
||
| const onFinish = async (values: ExportAzureBYOKFormData) => { |
Contributor
Author
There was a problem hiding this comment.
"values" is confusing word
| <Space direction="vertical" size="middle" style={{ display: "flex" }}> | ||
| <Card> | ||
| <h3 className="text-m font-bold mb-4">Key Identifiers (required)</h3> | ||
| <h3 className="text-m font-bold mb-4">Key Identifiers in this KMS (required)</h3> |
Contributor
Author
There was a problem hiding this comment.
added "in this KMS" to make things way more intuitive as an user who is exporting a key to multiple providers ("byok") gets very easely lost since each of them has his own vocab
| tags, | ||
| keyUsage, | ||
| undefined // wrappingKeyId | ||
| undefined, // wrappingKeyId |
Contributor
Author
There was a problem hiding this comment.
there might be a delta in the formatting rules
please ignore this for now, we can merge. I will adress lint/formatter in a later PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some bug that made it not possible to export azure byok keys
I am aware of the fomatting diffs. I will normalize that in a later PR.