Skip to content

improve SplitListValues allocation efficiency #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ucwong merged 1 commit into from
Jan 25, 2026
Merged

improve SplitListValues allocation efficiency #2624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions rlp/raw.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,40 @@ func CountValues(b []byte) (int, error) {
return i, nil
}

// SplitListValues extracts the raw elements from the list RLP-encoding blob.
func SplitListValues(b []byte) ([][]byte, error) {
b, _, err := SplitList(b)
if err != nil {
return nil, err
}
n, err := CountValues(b)
if err != nil {
return nil, err
}
var elements = make([][]byte, 0, n)

for len(b) > 0 {
_, tagsize, size, err := readKind(b)
if err != nil {
return nil, err
}
elements = append(elements, b[:tagsize+size])
b = b[tagsize+size:]
}
return elements, nil
}

// MergeListValues takes a list of raw elements and rlp-encodes them as list.
func MergeListValues(elems [][]byte) ([]byte, error) {
w := NewEncoderBuffer(nil)
offset := w.List()
for _, elem := range elems {
w.Write(elem)
}
w.ListEnd(offset)
return w.ToBytes(), nil
}

func readKind(buf []byte) (k Kind, tagsize, contentsize uint64, err error) {
if len(buf) == 0 {
return 0, 0, 0, io.ErrUnexpectedEOF
Expand Down
Loading