Skip to content

Conversation

@GREENRAT-K405
Copy link

Recording.2025-12-30.232017.mp4

I have made the node snap to the nearest grid point.
Simply turning on SnapGrid was not suffiecient (it would snap the centre of node to a grid point rather than the corners of node), that is why I had to add little stricter logic to snap the node properly with grid.

@GREENRAT-K405
Copy link
Author

@pradeeban please review the changes.

@GREENRAT-K405
Copy link
Author

@pradeeban I had added some logs in my previous PR to figure out the errors, it failed in the CI workflow. It is fixed now, the CI is working fine!

@pradeeban
Copy link
Member

Thanks. Why are you commenting out some console.error logs?

@GREENRAT-K405
Copy link
Author

@pradeeban actually the errors/logs I have commented out are the logs I had added in PR#251 (the previous PR) because I was checking where the abort error were occurring. These logs are places in try catch blocks of "save", "save as" and "open". I believe these aren't actual errors, I commented them out because they were failing the CI pipeline. I realised this after I pushed the code and when github CI script notified me.

In short, these were the logs I had added just for testing previously to find where the "abort" error was occuring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants