Open
Conversation
ghost
self-requested a review
ghost
reviewed
Sep 28, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Added some comments which could improve the deployment of the s3 static website.
|
|
||
|
|
||
|
|
||
| # Documentation: https://www.terraform.io/docs/language/providers/requirements.html |
There was a problem hiding this comment.
Change Documentation link to https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket#static-website-hosting
| # Documentation: https://www.terraform.io/docs/language/providers/requirements.html | ||
| # See also: [aws/aws_s3_bucket/simple] (https://github.com/ContainerSolutions/terraform-examples/tree/main/aws/aws_s3_bucket/simple) | ||
| # Explanation: Sets a Bucket for Static Website Hosting | ||
| # Now you have to add your files to the bucket index.html and also acces with this naming scheme , dependig on your region: |
There was a problem hiding this comment.
Consider adding 2 s3_bucket_object referencing 2 files, index.html and error.html, which can also be added to this repo. A simple index.html file can be found here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link related issues:
The following short checklist should be used to make sure your PR is of good quality, and can be merged easily:
./run.shworks correctly for all new examplesReviewers:
@ianmiell
@ttarczynski
@sanyer
@teszes
@choilmto