Support For Deploying Standalone Processors #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstehr
force-pushed
the
ns/wasm_processors
branch
from
654e0d2 to
2e056c1
Compare
nstehr
force-pushed
the
ns/wasm_processors
branch
from
2e056c1 to
73327f0
Compare
ssicard
approved these changes
Jun 20, 2025
| } | ||
| // handles standalone processors that need WASM downloaded | ||
| for _, p := range allProcessors { | ||
| if !strings.HasPrefix(p.Plugin, "builtin") && p.ProcessorURL != "" { |
Contributor
There was a problem hiding this comment.
All standalone processors have builtin prefixed on the front?
Contributor
Author
There was a problem hiding this comment.
From what I could tell..yes. This code was a refactor of the existing logic, which did the check the same way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This builds on #84. It adds the functionality to allow for the download and installation of a custom processor using the
ProcessorURLfield.The processor will be saved to the volume used by the conduit pod.
Right now, when the pod is recreated it will download the processor again. There is currently no checking of checksums, versions, etc if any are saved and will overwrite the existing processor, given the name being the same.
Fixes # (issue)
#10
Quick checks: