feat(pumpkin-proof-processor): Introduce the proof processor in the main branch#371
Open
maartenflippo wants to merge 15 commits intomainfrom
Open
feat(pumpkin-proof-processor): Introduce the proof processor in the main branch#371maartenflippo wants to merge 15 commits intomainfrom
maartenflippo wants to merge 15 commits intomainfrom
Conversation
ImkoMarijnissen
previously requested changes
Feb 23, 2026
maartenflippo
force-pushed
the
feat/proof-processor
branch
from
1e174b1 to
167662a
Compare
github-actions
bot
dismissed
ImkoMarijnissen’s stale review
Review re-requested
ImkoMarijnissen
previously requested changes
Feb 25, 2026
github-actions
bot
dismissed
ImkoMarijnissen’s stale review
Review re-requested
1 task
ImkoMarijnissen
approved these changes
Feb 27, 2026
Comment on lines
+124
to
+126
| // This will never fail, as the predicate is known to be unassigned. So | ||
| // this propagator only returns explicit conflicts and never empty | ||
| // domain conflicts. |
Contributor
There was a problem hiding this comment.
If this is the case, then shouldn't we make this clear by an assertion or by not using the ? operator?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proof processor is now implemented using the
Stateabstraction, simplifying the design that was buried in one of the experimental branches.feat(pumpkin-solver): Add a MiniZInc library that allows pumpkin to produce valid proofs.