Skip to content

Conversation

@j-c-c
Copy link
Collaborator

@j-c-c j-c-c commented Dec 17, 2025

Creates an intermediary base class CLMatrix to deploy the commonlines matrix build for only those classes that use it.

@j-c-c j-c-c self-assigned this Dec 17, 2025
@j-c-c j-c-c added the cleanup label Dec 17, 2025
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 93.61702% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.87%. Comparing base (edcbcea) to head (4af52c5).
⚠️ Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
src/aspire/abinitio/commonline_matrix.py 93.02% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1352      +/-   ##
===========================================
+ Coverage    90.74%   90.87%   +0.12%     
===========================================
  Files          136      135       -1     
  Lines        14689    14672      -17     
===========================================
+ Hits         13330    13333       +3     
+ Misses        1359     1339      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-c-c
Copy link
Collaborator Author

j-c-c commented Jan 8, 2026

Quick summary of work in this PR.

  • created an intermediary base class CLMatrix to deploy the commonlines build (cpu/gpu) and lazy evaluation of clmatrix to the commonline algos that use it. Namely, CLSync3N, CLSyncVoting, CLSymmetryC2 (for lazy eval only), CLSymmetryC3C4, CommonlineSDP/LUD/IRLS.
  • Some basic testing for class hierarchy and lazy evaluation
  • Fixed early-triggered log message for using precomputed clmatrix
  • validation testing that clmatrix results remain unaltered by the changes in this PR for all relevant classes (singles/doubles) on cpu and gpu.

@j-c-c j-c-c requested a review from garrettwrong January 8, 2026 20:43
garrettwrong
garrettwrong previously approved these changes Jan 9, 2026
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks!

g_sync,
)
from .commonline_base import CLOrient3D
from .commonline_matrix import CLMatrix
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you got lucky with the abc's here :D

@j-c-c j-c-c marked this pull request as ready for review January 9, 2026 20:11
@j-c-c j-c-c requested a review from janden as a code owner January 9, 2026 20:11
Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few things.

@j-c-c j-c-c merged commit 43d4215 into develop Jan 15, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants