-
Notifications
You must be signed in to change notification settings - Fork 25
CLMatrix Intermediary Base Class (CL Reorg part 2) #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1352 +/- ##
===========================================
+ Coverage 90.74% 90.87% +0.12%
===========================================
Files 136 135 -1
Lines 14689 14672 -17
===========================================
+ Hits 13330 13333 +3
+ Misses 1359 1339 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Quick summary of work in this PR.
|
garrettwrong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thanks!
src/aspire/abinitio/__init__.py
Outdated
| g_sync, | ||
| ) | ||
| from .commonline_base import CLOrient3D | ||
| from .commonline_matrix import CLMatrix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you got lucky with the abc's here :D
0b495ba to
5d3d25f
Compare
janden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few things.
Creates an intermediary base class
CLMatrixto deploy the commonlines matrix build for only those classes that use it.