Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

Experimental recons (as published in gallery/experiments) at 8577e1d were as follows:

10028 @ 179 pixels took 9 hours, yielding FSC 9.8A with 0.5 cutoff
10073 @ 129 pixels took 8 hours, yieding FSC 18.4A with 0.5 cutoff

10073 is meeting and/or exceeding the JSB2017 publication. 10028 is behind by about 2A.

10028 left, 10073 right

Screenshot 2025-12-15 at 8 11 04 AM Screenshot 2025-12-15 at 8 11 42 AM Screenshot 2025-12-15 at 8 12 10 AM

Draft release notes below:


ASPIRE v0.14.2 is patch release, adding bug fixes, updates and some code refactoring.

This release provides the following features:

  • Port of ASPIRE MATLAB's fast rotation by shearing
  • ImageSource.save Optics Block

Bug fixes:

  • Commonline based image shift estimation
  • Class average metadata indices

Code cleanup:

  • Commonlines Class Reorganization (part 1)
  • Update FLE tests following cufinufft updates
  • Numpy pickle warnings

Systems/CI Updates:

  • cvxpy release packaging bug (numpy version)
  • Scikit PCA wrapper updates
  • Flaky Adjoint test

@garrettwrong garrettwrong requested a review from j-c-c December 15, 2025 14:58
@garrettwrong garrettwrong self-assigned this Dec 15, 2025
@garrettwrong garrettwrong added the CI Continuous Integration label Dec 15, 2025
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good! Draft release notes look good.

@garrettwrong garrettwrong marked this pull request as ready for review December 15, 2025 16:07
@garrettwrong garrettwrong requested a review from janden as a code owner December 15, 2025 16:07
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 97.40458% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.74%. Comparing base (c90ed83) to head (6efd7b6).
⚠️ Report is 91 commits behind head on main.

Files with missing lines Patch % Lines
src/aspire/image/image.py 66.66% 9 Missing ⚠️
src/aspire/abinitio/sync_voting.py 96.51% 3 Missing ⚠️
src/aspire/numeric/complex_pca/complex_pca.py 77.77% 2 Missing ⚠️
src/aspire/abinitio/commonline_base.py 96.42% 1 Missing ⚠️
src/aspire/image/rotation.py 99.03% 1 Missing ⚠️
src/aspire/source/image.py 98.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1350      +/-   ##
==========================================
+ Coverage   90.65%   90.74%   +0.09%     
==========================================
  Files         133      136       +3     
  Lines       14433    14688     +255     
==========================================
+ Hits        13084    13329     +245     
- Misses       1349     1359      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@garrettwrong garrettwrong merged commit ba8ec6a into main Dec 16, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants