-
Notifications
You must be signed in to change notification settings - Fork 25
[WIP] MicrographSource/Image updates
#1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
After a few attempts I was able to get this down to a somewhat more reasonable change set. I've made a few other things (migrated things I saw towards classmethods) a bit more consistent while I was in there in case more surgery is required down the road. I still need to hit the filtering methods so that CTF can be applied to these rectangles. etc. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1288 +/- ##
===========================================
- Coverage 90.74% 90.64% -0.11%
===========================================
Files 136 136
Lines 14689 14722 +33
===========================================
+ Hits 13330 13345 +15
- Misses 1359 1377 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e85b929 to
e35b9a5
Compare
bbc5cf7 to
90906c9
Compare
90906c9 to
dc1a0ac
Compare
e49a44e to
43efc6a
Compare
|
Looks like this is jammed up from a backwards incompatible change in the new scipy release 1.17.0 (Jan 10th). I'll make an issue and patch that, then come back here. |
|
43efc6a to
f6b0c87
Compare
Fix
MicrographSourceso it can load and operate on EMPIAR experimental data (eg 10061). These datasets often have rectangular shapes.