Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

Fix MicrographSource so it can load and operate on EMPIAR experimental data (eg 10061). These datasets often have rectangular shapes.

@garrettwrong garrettwrong self-assigned this Jun 6, 2025
@garrettwrong garrettwrong added bug Something isn't working cleanup labels Jun 6, 2025
@garrettwrong
Copy link
Collaborator Author

After a few attempts I was able to get this down to a somewhat more reasonable change set. I've made a few other things (migrated things I saw towards classmethods) a bit more consistent while I was in there in case more surgery is required down the road.

I still need to hit the filtering methods so that CTF can be applied to these rectangles. etc.

@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

❌ Patch coverage is 63.79310% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.64%. Comparing base (edcbcea) to head (f6b0c87).

Files with missing lines Patch % Lines
src/aspire/source/micrograph.py 50.00% 16 Missing ⚠️
src/aspire/image/image.py 75.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1288      +/-   ##
===========================================
- Coverage    90.74%   90.64%   -0.11%     
===========================================
  Files          136      136              
  Lines        14689    14722      +33     
===========================================
+ Hits         13330    13345      +15     
- Misses        1359     1377      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@garrettwrong
Copy link
Collaborator Author

Looks like this is jammed up from a backwards incompatible change in the new scipy release 1.17.0 (Jan 10th). I'll make an issue and patch that, then come back here.

@garrettwrong
Copy link
Collaborator Author

Looks like this is jammed up from a backwards incompatible change in the new scipy release 1.17.0 (Jan 10th). I'll make an issue and patch that, then come back here.

#1353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants