Toggle issue fixed, Merge after Zoe pushes up her branch #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Working correctly, the "n" key should toggle the music on and off with a single click. musicToggle is now a global variable, in order to fix the issue of some rooms not being consistent, and still requiring and extra button press to turn off music. Going forward, a music toggle icon should appear in the right side of the screen, small enough to not distract or clutter the view, but big enough to be noticed for utility. |
Changing the image to something more less overtly red.
JerichoSM
changed the title
Collaborator
|
Looks great!
|
fenwickjb
reviewed
Jun 24, 2020
Collaborator
fenwickjb
left a comment
fenwickjb
left a comment
There was a problem hiding this comment.
I left a comment on the PR page. Looks great, 3 hopefully quick fixes mentioned there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No images yet, but the underlying issue with the button not working is fixed.