Change deleted field to DATETIME and use CURRENT_TIMESTAMP #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the 'deleted' column in the characters table from DATE to DATETIME in install.sql for more precise deletion tracking. Modified DeleteCharacter to set the deleted timestamp using CURRENT_TIMESTAMP() instead of curdate().
|
It's a good idea, but you also need to use the the TIMESTAMP datatype in the column |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the 'deleted' column in the characters table from DATE to DATETIME in install.sql for more precise deletion tracking. Modified DeleteCharacter to set the deleted timestamp using CURRENT_TIMESTAMP() instead of curdate().
Should make sense to save timestamp rather than just date.
E: This is reopen of #29 which was closed due to fork being deleted