Skip to content

Conversation

@bagashvilit
Copy link
Contributor

@bagashvilit bagashvilit commented Jun 10, 2022

This pull request refactors commitcanvas with plugin-based architecture allowing users to customize commitcanvas.

What is the current behavior?

Currently, commitcanvas uses only default checks

What is the new behavior if this PR is merged?

This change will allow the users to create and disable their own checks

Type of change

Please describe the pull request as one of the following:

  • Bug fix
  • Breaking change
  • New feature
  • Documentation update
  • Other

Other information

This PR has:

  • Commit messages that are correctly formatted
  • Tests for newly introduced code
  • Docstrings for newly introduced code

Developers

@bagashvilit
@

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #23 (0b832c5) into master (df324df) will increase coverage by 33.67%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           master       #23       +/-   ##
============================================
+ Coverage   66.32%   100.00%   +33.67%     
============================================
  Files           5         5               
  Lines          98        62       -36     
============================================
- Hits           65        62        -3     
+ Misses         33         0       -33     
Impacted Files Coverage Δ
commitcanvas/__init__.py 100.00% <100.00%> (ø)
commitcanvas/hookspecs.py 100.00% <100.00%> (ø)
commitcanvas/host.py 100.00% <100.00%> (ø)
commitcanvas/utils.py 100.00% <100.00%> (ø)
commitcanvas_plugins.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df324df...0b832c5. Read the comment docs.

@bagashvilit bagashvilit self-assigned this Jul 1, 2022
@bagashvilit bagashvilit added enhancement New feature or request documentation Improvements or additions to documentation labels Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant