Conversation
|
|
Author
|
Closes #47 |
adhit-r
requested review from
dinpraka and
sai100
and removed request for
sai100
Contributor
Contributor
jansiraj
requested changes
Apr 21, 2025
Collaborator
jansiraj
left a comment
jansiraj
left a comment
There was a problem hiding this comment.
Coding is fine but Functionality seems to be not working while testing
|
|
||
| argparser.add_argument( | ||
| "-a", | ||
| "--archived", |
Collaborator
There was a problem hiding this comment.
please update the argument parser as --include-archived or -ia and for forked --include-forked or -if for better user understanding or also change help message like "Pass Yes or No to include archived repositories for search. Default is Yes". change in all the respective files wherever used
jansiraj
requested changes
May 12, 2025
| self._base_url, | ||
| params={ | ||
| "q": f"{search_query} {additional_qualifiers}", | ||
| "q": q_string, |
Collaborator
There was a problem hiding this comment.
search api Not filtering archived repos correctly.Need to fix it
| self._base_url, | ||
| params={ | ||
| "q": f"{search_query}", | ||
| "q": q_string, |
Collaborator
There was a problem hiding this comment.
search api Not filtering archived repos correctly.Need to fix it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds flags --archived and --forked to each of the main files.
Users can specify Yes or No to include forked or archived repositories in the results.