feat: displaced note heads for multiple voices #2430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danielku15
force-pushed
the
feature/displace-voice
branch
from
3b2a24c to
117920f
Compare
Danielku15
force-pushed
the
feature/displace-voice
branch
from
78a46ac to
2516271
Compare
Danielku15
force-pushed
the
feature/displace-voice
branch
from
e3a6be9 to
b12926d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2247
Proposed changes
Implements the new displacement logic for multiple voices. It's quite a range of individual rules, but the logic should not be very performance costly. It's mostly checking for overlaps per note-chord and then applying an offset. Generally we need a second layout pass for handling multi-voice bars, but that's acceptable for now.
Checklist
Further details