refactor: Decouple beaming helper #2427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danielku15
force-pushed
the
feature/beaminghelper-decouple
branch
from
e02ed74 to
e1d38c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Relates to #2247
Proposed changes
Another refactoring in preparation for #2247. Beside fixing various alignment problems this refactoring eliminates the direct use of the beaming helper and related alignment logic.
For #2247 some further refactoring is needed on how we generally create and align note heads and the related spacing. This refactoring makes some things easier in calculating the note head locations.
Checklist
Further details