This repository was archived by the owner on Aug 17, 2024. It is now read-only.
London9_Node-Coursework-Week2 _Mo Nahvi#274
Open
monahvi wants to merge 4 commits intoCodeYourFuture:masterfrom
Open
London9_Node-Coursework-Week2 _Mo Nahvi#274monahvi wants to merge 4 commits intoCodeYourFuture:masterfrom
monahvi wants to merge 4 commits intoCodeYourFuture:masterfrom
Conversation
start 01
|
|
||
| res.status(204).send("Message has been deleted!"); | ||
| } | ||
| res.status(404).send("Message not found!"); |
There was a problem hiding this comment.
Nice returning error messages and correct status codes 🥳
server.js
Outdated
| res.json({ messages }); | ||
| }); | ||
|
|
||
| app.get("/messages/id", (req, res) => { |
There was a problem hiding this comment.
Does this one work? I see in the others you have used a colon like :id
server.js
Outdated
| const cors = require("cors"); | ||
|
|
||
| const app = express(); | ||
| let app = express(); |
There was a problem hiding this comment.
Why do we change this to let? I dont see it being reassigned
line 41 solved
change the let
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?