London 9- Tuan Nguyen-JS-core1-week1 #534
Conversation
|
Hi there @Jacknguyen4438, |
Dedekind561
left a comment
Dedekind561
left a comment
There was a problem hiding this comment.
Well done on getting your first piece of coursework done!
My main piece of feedback at this point is around variable names - how can you improve the naming of variables in order to convey more meaning in your programs.
|
|
||
| function addTaxAndFormatCurrency() {} | ||
| function addTaxAndFormatCurrency(product) { | ||
| let amountOne=( (product*1.2).toFixed(2)).toString(); |
There was a problem hiding this comment.
Hello @Jacknguyen4438 ,
Can you think of a better variable name than amountOne? Think about the calculation you're doing here and what it means in order to help you come up with a clearer variable name. Remember your variable names should convey meaning, as your code will be read by other humans.
| function addTaxAndFormatCurrency() {} | ||
| function addTaxAndFormatCurrency(product) { | ||
| let amountOne=( (product*1.2).toFixed(2)).toString(); | ||
| // let amountTwo= parseFloat(amountOne); |
There was a problem hiding this comment.
👓 Remember to remove old comments
|
|
||
| function calculateSalesTax() {} | ||
| function calculateSalesTax(productPrice) { | ||
| let productTotal=productPrice+(productPrice*0.2); |
There was a problem hiding this comment.
You have no spaces between the variable names and the expression on the right hand side. Double check the README for instructions on how to format your code
Jacknguyen4438
changed the title
2 participants
This is my answer for the home work
Your Details
Homework Details
Notes
What did you find easy?using var key word and function syntax.
What did you find hard? How the test work
What do you still not understand?how to calculation in function
Any other notes?no