Fix return type

[stefket]

In version 4.0.8, the following error occurs:

CodeWithDennis\FilamentSelectTree\SelectTree::getResults(): Return value must be of type Illuminate\Support\Collection|array|null, Illuminate\Support\LazyCollection returned

This commit updates the return type to ensure compatibility.

[CodeWithDennis]

Shouldn't it support both?

[CodeWithDennis]

@stefket

[stefket]

@CodeWithDennis

Sorry Dennis for not getting back to you sooner.

It’s been a while, and I honestly can’t remember exactly when the issue occurs.

I’ll take another look right away and get back to you as soon as I have more details.

[stefket]

I have found the place in my project, where the error occurs with version 4.0.8:

SelectTree::make('nav_item_id')
    ->query(fn () => NavItem::query(), 'text', 'parent_id')
    ->enableBranchNode()
    ->defaultOpenLevel(4)
    ->storeResults()
    ->disabledOptions(function (SelectTree $component): array {
        return $component
            ->getResults()
            ->filter(fn ($item) => filled($item->content_id))
            ->pluck('id')
            ->toArray();
    })

Accessing getResults inside the disabledOptions callback causes the error in my project.

But I agree with you — it would make more sense to allow both a LazyCollection and a regular Collection as the return type here. I’ve just corrected that.

[CodeWithDennis]

@CodeWithDennis

Sorry Dennis for not getting back to you sooner.

It’s been a while, and I honestly can’t remember exactly when the issue occurs.

I’ll take another look right away and get back to you as soon as I have more details.

No worries and thanks!