Feature/v2 #26
Merged
Feature/v2 #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .yarn/releases/yarn-4.8.0.cjs # .yarnrc.yml # package.json # src/components/Layout/index.jsx # src/contexts/MainContextProvider/index.jsx # src/pages/donate/index.jsx # src/pages/software/deadpix/index.jsx # src/reducers/MainReducer/Actions/actionTypes.js # src/reducers/MainReducer/Actions/index.js # src/reducers/MainReducer/index.jsx # yarn.lock
CodeDead
added
enhancement
There was a problem hiding this comment.
Copilot reviewed 336 out of 346 changed files in this pull request and generated 2 comments.
Files not reviewed (10)
- .dockerignore: Language not supported
- .eslintignore: Language not supported
- .eslintrc.json: Language not supported
- .nvmrc: Language not supported
- .stylelintignore: Language not supported
- .stylelintrc.json: Language not supported
- Dockerfile: Language not supported
- components/FeatureCard/index.module.css: Language not supported
- components/Footer/index.module.css: Language not supported
- components/NavBar/navbar.module.css: Language not supported
| className={classes.link} | ||
| data-active={pageIndex === 1 ? true : undefined} | ||
| style={{ display: 'flex', alignItems: 'center', cursor: 'pointer', flexGrow: 1 }} | ||
| href="/software" |
There was a problem hiding this comment.
Using the Box component with an href attribute may lead to semantic and accessibility issues since Box is not inherently an anchor tag. Consider replacing it with a Link component or a native anchor element to ensure proper semantics.
Comment on lines
+31
to
+32
| (renderStory: any) => <ColorSchemeWrapper>{renderStory()}</ColorSchemeWrapper>, | ||
| (renderStory: any) => <MantineProvider theme={theme}>{renderStory()}</MantineProvider>, |
There was a problem hiding this comment.
The ordering of the MantineProvider and ColorSchemeWrapper may prevent the useMantineColorScheme hook from accessing its context. Consider wrapping ColorSchemeWrapper inside MantineProvider to ensure proper context availability.
Suggested change
| (renderStory: any) => <ColorSchemeWrapper>{renderStory()}</ColorSchemeWrapper>, | |
| (renderStory: any) => <MantineProvider theme={theme}>{renderStory()}</MantineProvider>, | |
| (renderStory: any) => ( | |
| <MantineProvider theme={theme}> | |
| <ColorSchemeWrapper>{renderStory()}</ColorSchemeWrapper> | |
| </MantineProvider> | |
| ), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.