Replace favicon #49
Merged
Replace favicon #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aedwardg
reviewed
Jan 26, 2025
Collaborator
aedwardg
left a comment
aedwardg
left a comment
There was a problem hiding this comment.
It looks a little squished along the x axis, but I think that's fine for now. Better than the Vite logo anyway.
Do you think you can run it through https://favicon.io/favicon-converter and follow the instructions there for adding in the generated files?
aedwardg
approved these changes
Feb 3, 2025
Collaborator
aedwardg
left a comment
aedwardg
left a comment
There was a problem hiding this comment.
I'm approving because the favicon looks good now.
However, a potential followup might be setting it up the rest of the way, as described by favicon.io:
I don't know how important it is that we follow those, but I know it's best practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this solving?
Closes #36
Description
I apologize for not assigning the issue, but it was a sudden inspiration. But I just used the recently added png as the new favicon.
Any helpful knowledge/context for the reviewer?
Feelings gif (optional)
Please make sure you've attempted to meet the following coding standards