Reorganize files into new directories #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aedwardg
reviewed
Jan 24, 2025
Collaborator
aedwardg
left a comment
aedwardg
left a comment
There was a problem hiding this comment.
Overall, looks good. Just a couple of nits around the imports.
If they work as I think they do, would you mind updating them? Thanks!
src/components/Layout/index.tsx
Outdated
Comment on lines
1
to
2
| import Header from "./Header"; | ||
| import Footer from "./Footer"; | ||
| import Header from "./Header.tsx"; | ||
| import Footer from "./Footer.tsx"; |
Collaborator
There was a problem hiding this comment.
nit: I believe these don't need the .tsx ending, and I think it's convention to leave it off
src/routes/Home/index.tsx
Outdated
Comment on lines
1
to
4
| import Hero from "./Hero.tsx"; | ||
| import Features from "./Features.tsx"; | ||
| import CTA from "./CTA.tsx"; | ||
| import Showcase from "./Showcase.tsx"; |
src/main.tsx
Outdated
Comment on lines
5
to
7
| import Layout from "./components/Layout.tsx"; | ||
| import Home from "./routes/Home.tsx"; | ||
| import About from "./routes/About.tsx"; | ||
| import Layout from "./components/Layout/index.tsx"; | ||
| import Home from "./routes/Home/index.tsx"; | ||
| import About from "./routes/About/index.tsx"; |
Collaborator
There was a problem hiding this comment.
Because these components are exported as default, I believe we can change all of these to leave off the
/index.tsx.
E.g.
import Home from "./routes/Home";
Contributor
Author
|
Ah yes. I think it was just some IDE nonsense that put them in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this solving?
No issue created for this PR
Description
Organized components into directories for readability and reusability. The Layout directory contains the Output for React Router, and the Header and Footer components. The new shared directory will contain any components to be shared over multiple routes.
The routes directory had sub directories introduced for each route that will contain components used only in that route.
Any helpful knowledge/context for the reviewer?
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
Please make sure you've attempted to meet the following coding standards