COD-2032: Allow multiple uploads in a single job #199
Merged
+199
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fargito
force-pushed
the
cod-2032-allow-multiple-uploads-in-a-single-job
branch
from
3f9ac0a to
69dcc00
Compare
fargito
force-pushed
the
cod-2032-allow-multiple-uploads-in-a-single-job
branch
from
69dcc00 to
f3fcd31
Compare
GuillaumeLagrange
approved these changes
Jan 19, 2026
| } | ||
| } | ||
| } | ||
| None => None, |
Contributor
There was a problem hiding this comment.
You could use .map on self.get_run_provider_run_part() to avoid the match arm None => None
| .join(".codspeed") | ||
| .join("run-state") | ||
| .join(run_id) | ||
| .join(format!("{}.json", &run_part_id_hash[..16])); |
Contributor
There was a problem hiding this comment.
is there a particular reason we truncate this hash ?
fargito
force-pushed
the
cod-2032-allow-multiple-uploads-in-a-single-job
branch
from
ff7f46d to
f3fcd31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.