Skip to content

Conversation

@not-matthias
Copy link
Member

@not-matthias not-matthias commented Jan 15, 2026

We added a debug log in #17 which now messes with the formatting of the benchmark library:

Timer precision: 20 ns
alloc        fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ allocate  [DEBUG] instrument-hooks: CodSpeed runner not detected, continuing without profiling
[DEBUG] instrument-hooks: CodSpeed runner not detected, continuing without profiling
Hello, world!
[1, 2, 3]
{"key": "value"}

let's revert this to be transparent


Also lowered the timeout to avoid long hangs at the start of the benchmark binary. 1s should be more than enough since the runner is already ready when the benchmark binary is launched.

@not-matthias not-matthias force-pushed the cod-1978-benchmarks-cant-be-run-without-codspeed-anymore-2 branch from c80a540 to 8e6c3d2 Compare January 15, 2026 17:40
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@not-matthias not-matthias merged commit 8e6c3d2 into main Jan 16, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants