Add LIMITs to TPC-H queries 2, 3, 10, 18 and 21
#5251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds LIMIT clauses to TPC-H queries 2, 3, 10, 18, and 21 as required by paragraph 2.1.2.9 of the TPC-H benchmark specification. Additionally, it standardizes the SQL keyword casing in query 15 from lowercase to uppercase for consistency.
Changes:
- Added
LIMITclauses to queries 2, 3, 10, 18, and 21 with values of 100, 10, 20, 100, and 100 respectively - Converted SQL keywords in query 15 from lowercase to uppercase for consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Blargian
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The document that defines TPC-H benchmark does not have
LIMITstatements in some of the queries. But in paragraph 2.1.2.9, they ask to add them for queries 2, 3, 10, 18 and 21, which we do in this PR.Also, a cosmetic improvement for Q15.