GH-45099: [C++] Avoid static const variable in the status.h #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ache#45100) ### Rationale for this change The `Status::message` function below has defined a static const string in the header file which may cause troubles in different translation units. ``` const std::string& message() const { static const std::string no_message = ""; return ok() ? no_message : state_->msg; } ``` ### What changes are included in this PR? Move the definition of `Status::message` function into the source file. ### Are these changes tested? Pass CIs. ### Are there any user-facing changes? No. * GitHub Issue: apache#45099 Authored-by: Gang Wu <ustcwg@gmail.com> Signed-off-by: Gang Wu <ustcwg@gmail.com> (cherry picked from commit a2f1988)
|
|
|
❌ GitHub issue apache#45099 could not be retrieved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of apache#45100 to our branch.