Skip to content

feat: 체결 완료 시 알림 기능 추가#138

Merged
caniro merged 5 commits intodevfrom
feat/trade-notify
Jun 8, 2025
Merged

feat: 체결 완료 시 알림 기능 추가#138
caniro merged 5 commits intodevfrom
feat/trade-notify

Conversation

@caniro
Copy link
Contributor

@caniro caniro commented Jun 7, 2025

✨ 작업내용

  • 체결 완료 시 알림 기능 추가 658791c

@caniro caniro self-assigned this Jun 7, 2025
@caniro caniro linked an issue Jun 7, 2025 that may be closed by this pull request
1 task
@caniro caniro force-pushed the feat/trade-notify branch from 658791c to 224a004 Compare June 7, 2025 13:37
@caniro
Copy link
Contributor Author

caniro commented Jun 7, 2025

제가 가끔 force-push 하는 이유가, PR 올려놓고 dev 브랜치 rebase했다가 추가 커밋하면 꼬여가지고.. ㅠ
그냥 브랜치 최신화한거라 리뷰해주실 땐 신경 안 쓰셔도 됩니닷

@caniro
Copy link
Contributor Author

caniro commented Jun 7, 2025

@109an94 github actions 빌드 시 테스트 하나가 계속 실패하는데 봐주실 수 있나요 ㅠㅠ

RefresherRunnerTest STANDARD_OUT
    [2025-06-07 13:38:16.877] [Test worker] INFO  o.s.t.c.s.AnnotationConfigContextLoaderUtils - Could not detect default configuration classes for test class [com.cleanengine.coin.realitybot.api.RefresherRunnerTest]: RefresherRunnerTest does not declare any static, non-private, non-final, nested classes annotated with @Configuration.
    [2025-06-07 13:38:16.881] [Test worker] INFO  o.s.b.t.c.SpringBootTestContextBootstrapper - Found @SpringBootConfiguration com.cleanengine.coin.CoinApplication for test class com.cleanengine.coin.realitybot.api.RefresherRunnerTest

RefresherRunnerTest > 어플리케이션 실행  호가 단위 수집 FAILED
    Wanted but not invoked:
    unitPriceRefresher.run(
        <any org.springframework.boot.ApplicationArguments>
    );
    -> at com.cleanengine.coin.realitybot.api.UnitPriceRefresher.run(UnitPriceRefresher.java:31)

    However, there were exactly 2 interactions with this mock:
    unitPriceRefresher.getUnitPriceByTicker(
        "BTC"
    );
    -> at com.cleanengine.coin.realitybot.service.OrderGenerateService.generateOrder(OrderGenerateService.java:52)

    unitPriceRefresher.getUnitPriceByTicker(
        "TRUMP"
    );
    -> at com.cleanengine.coin.realitybot.service.OrderGenerateService.generateOrder(OrderGenerateService.java:52)
        at app//com.cleanengine.coin.realitybot.api.UnitPriceRefresher.run(UnitPriceRefresher.java:31)
        at app//com.cleanengine.coin.realitybot.api.RefresherRunnerTest.runwithrefrecher(RefresherRunnerTest.java:22)

@caniro caniro requested a review from 109an94 June 7, 2025 13:45
@bongj9
Copy link
Contributor

bongj9 commented Jun 7, 2025

기능 만드시고 테스트까지 다 하시고 주말에 작업하시느라 고생하셨습니다!!

@109an94
Copy link
Contributor

109an94 commented Jun 7, 2025

해당 문제는 제 테스트 코드인 RefresherRunnerTest 가 실행 시 스프링부트 시작할 때 spybean보다 더 빨리 동작되어서 발생하는 문제였던 것 같습니다.
그래서 전체 테스트하는 게 아닌 extendwith으로 변경하고 spy로 작동 확인만 하도록 하단의 코드를 작성했는데 수정 후 pr날리겠습니다!

@caniro caniro requested a review from Junh-b June 7, 2025 16:04
@investfuture-sonarqube1
Copy link

Failed Quality Gate failed

  • 0.00% Coverage on New Code (is less than 80.00%)

Project ID: CleanEngine_cleanengine-be_2b6f2f63-fa39-426c-b9c7-8aa127fd14d8

View in SonarQube

@caniro caniro merged commit 6238ad7 into dev Jun 8, 2025
1 check passed
@caniro caniro deleted the feat/trade-notify branch June 8, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BE] 체결 시 알림 전송

4 participants