Feat/user #133
Merged
Feat/user #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…참조 방지 - account 도메인의 로직이 필요한 게 아닌, 단순 accountId가 필요한 것이므로 Repository를 사용하는 것이 더 적합하다고 판단되어 변경하였음
|
Closed
4 tasks
Contributor
|
주문 생성봇의 시작지점이 ApiScheduler가 아니라 SchedulerConfig로 이동됨에 따라, WorkingServerProfile annotation도 그쪽으로 옮겨져야 하는 것으로 생각되네요. |
Junh-b
approved these changes
Jun 6, 2025
Contributor
Junh-b
left a comment
Junh-b
left a comment
There was a problem hiding this comment.
테스트 내용을 보니 백그라운드 로직에 영향을 받지 않게 id를 설정하셔서 백그라운드 로직에 의해 테스트가 깨지거나 하는 일은 없을 것 같네요.
그래도 통합테스트를 수행하며 백그라운드 로직이 돌면 약간의 성능이슈가 있을 수 있으니, profile 관련 설정 수정되면 다시 it profile 설정하시는 것이 좋을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 작업내용
it를 작성하면@WorkingServerProfile로 지정된ApiScheduler가SchedulerConfig에 주입되지 않는 것 같은데, 저만 그런건지 확인 한번 부탁드립니다.