Merged
Conversation
builder 패턴 사용시 build 내용이 누락되던 issue 해결
TradeExecutedEvent가 체결 당시의 맥락을 온전히 담을 수 있도록 OrderId를 추가로 넣는 방식으로 변환했습니다.
기존 체결이 완료되었을 때, 동기적으로 호출하던 내용을 EventHandler 방식으로 변경했습니다.
TradeExecutedEvent 발생시 핸들러가 실행되도록 수정했습니다.
주문 복원 기능에 대해서도 일관적으로 동작하도록 수정했습니다.
EventListener의 class명을 명시적으로 기재하지 않고, method의 spec을 기반으로 Spring이 event를 주입하는 방식으로 변경했습니다.
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
caniro
approved these changes
Jun 4, 2025
Contributor
caniro
left a comment
caniro
left a comment
There was a problem hiding this comment.
불필요 삭제 리팩토링 및 복원 정상화 고생하셨습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 작업내용
🐞 이슈사항