Open
Conversation
…king # Conflicts: # plugins/simpleadminhacks-paper/src/main/java/com/programmerdan/minecraft/simpleadminhacks/hacks/basic/NameLocker.java
Contributor
Author
|
Fixed combining items for repair with name-locked items and adding enchantments from books. Also fixed using >1 honeycomb casuing the rest of the honeycomb left in the anvil to be deleted. |
Contributor
Author
|
Review @okx-code 🥹? |
okx-code
reviewed
Feb 17, 2026
|
|
||
| public class NameLockerFMListener implements Listener { | ||
|
|
||
| NamespacedKey lockedKey; |
Contributor
There was a problem hiding this comment.
Why is this package private? Should be private and final ideally
okx-code
reviewed
Feb 17, 2026
|
|
||
| public class NameLocker extends BasicHack { | ||
|
|
||
| final NamespacedKey lockedKey = new NamespacedKey(plugin, "name-locked"); |
okx-code
reviewed
Feb 17, 2026
| result.editMeta(meta -> { | ||
| meta.setDisplayName(event.getView().getRenameText()); | ||
| meta.getPersistentDataContainer().set(lockedKey, PersistentDataType.BOOLEAN, true); | ||
| meta.lore(List.of(Component.text().content("Name-locked").build())); // Just to make it clear. If we can change the message in the anvil this should be removed. |
Contributor
There was a problem hiding this comment.
do we want to wipe the lore for these kinds of items?
okx-code
requested changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows locking item names by combining them with honeycomb in an anvil. Locked items cannot be renamed by a player and cannot be wordbanked (though this is only necessary if items are locked with their default names as named items cannot be wordbanked). See my comments for bits I couldn't figure out but that would be nice, like changing the "Too Expensive!" text.