Skip to content

Fix resource URI generation #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smcor3dump wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix resource URI generation #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
### New in 0.10.3 (Released 2022/05/04)

Bug fixes

- Fix resource URI generation.

### New in 0.10.2 (Released 2022/04/18)

New features
Expand Down
4 changes: 2 additions & 2 deletions SODA.Tests/SodaUriTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,13 +177,13 @@ public void ForResourceAPI_With_Invalid_ResourceId_Throws_ArgumentOutOfRangeExce
public void ForResourceAPI_With_Valid_Arguments_Creates_ResourceAPI_Uri()
{
var uri = SodaUri.ForResourceAPI(StringMocks.Host, StringMocks.ResourceId);
StringAssert.AreEqualIgnoringCase(String.Format("/resource/{0}", StringMocks.ResourceId), uri.LocalPath);
StringAssert.AreEqualIgnoringCase(String.Format("/resource/{0}.json", StringMocks.ResourceId), uri.LocalPath);

uri = null;
string rowId = "rowId";

uri = SodaUri.ForResourceAPI(StringMocks.Host, StringMocks.ResourceId, rowId);
StringAssert.AreEqualIgnoringCase(String.Format("/resource/{0}/{1}", StringMocks.ResourceId, rowId), uri.LocalPath);
StringAssert.AreEqualIgnoringCase(String.Format("/resource/{0}/{1}.json", StringMocks.ResourceId, rowId), uri.LocalPath);
}

[TestCase(StringMocks.NullInput)]
Expand Down
3 changes: 2 additions & 1 deletion SODA/SODA.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<PackageId>CSM.SodaDotNet</PackageId>
<PackageTags>API OpenData Socrata SODA</PackageTags>
<Version>0.10.2</Version>
<Version>0.10.3</Version>
<Copyright>Copyright 2022 City of Santa Monica, CA</Copyright>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion SODA/Utilities/SodaUri.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public static Uri ForResourceAPI(string socrataHost, string resourceId, string r
url = String.Format("{0}/{1}", url, rowId);
}

return new Uri(url);
return new Uri(url + ".json");
}

/// <summary>
Expand Down
2 changes: 2 additions & 0 deletions Utilities/Utilities.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<PackageId>CSM.SodaDotNet.Utilities</PackageId>
<PackageTags>EWS Excel SODA</PackageTags>
<Version>0.10.3</Version>
<Copyright>Copyright 2022 City of Santa Monica, CA</Copyright>
</PropertyGroup>

<ItemGroup>
Expand Down