Open
Conversation
Added support for Python 3.11
ecoen66
commented
Dec 13, 2023
Contributor
Author
ecoen66
left a comment
ecoen66
left a comment
There was a problem hiding this comment.
Sorry, I realized I had left out a few of the fixes that allowed me to use this with Python 3.11 and circumvented some TLS cert issues.
vvb
reviewed
Dec 13, 2023
| # This is the only difference; default wrap_socket uses SSLv23 | ||
| self.sock = ssl.wrap_socket(sock, self.key_file, self.cert_file, | ||
| ssl_version=ssl.PROTOCOL_TLSv1) | ||
| cert_reqs=ssl.CERT_NONE, ssl_version=ssl.PROTOCOL_TLSv1_2) |
Member
There was a problem hiding this comment.
This would need some testing across various IMC releases and Hardware combinations. Let me check who can help with this.
Contributor
Author
There was a problem hiding this comment.
Ok, thanks. My home lab is pretty dated... No M5 or higher servers.
|
This one is good. How soon can we have this merged? |
|
Is this project still alive? We would like to take a dependency on this library but we would likely need this to be merged. |
|
This project is not actively updated. This PR can be ignored |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for Python 3.11
Added support for CNR server.
Fixed some certificate authentication issues.