Open
Conversation
Use SERVICE_TAGS to tell on which domain should the service be served.
removed marathon stuff added service naming
Using @eesprit proposal
Added example without --net host
The docker cache was used during last build, it somehow ended up with extra data.
Upgrading from Alpine 3.3 to 3.4 adds a weight 8MB (+33%)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the many changes I made to haproxy-consul ;-)
The most important one is the support of multidomains and the removal of
HAPROXY_DOMAINto useSERVICE_TAGSinstead (ref #18). Be aware that this is a breaking change. Maybe you could keep theHAPROXY_DOMAINin theconsul.tmplfile and use it if it's set.I updated the
README.md, I wacked the toc because I didn't find the markdown-toc tool and didn't want to leave it outdated. You might want to rework the README.md file it's getting kind of fat. Maybe some stuff could go to the wiki.