This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Add support for KDE Plasma DE with fix when the script worked only once#3
Open
jiriks74 wants to merge 10 commits intoChrisTitusTech:masterfrom
Open
Add support for KDE Plasma DE with fix when the script worked only once#3jiriks74 wants to merge 10 commits intoChrisTitusTech:masterfrom
jiriks74 wants to merge 10 commits intoChrisTitusTech:masterfrom
Conversation
Fix bug where running the script would change the wallpaper only once in kde
Author
|
Don't worry about the other commits. I left config for my pc and subreddits, some leftover files from vscode and build files. The fix itself is 8b08bc0 |
jiriks74
changed the title
Author
|
Hi, i saw your comment in the other pull request. I have a working version here, try it out. |
Author
|
I just added a check where if user deleted the blank file or this script was used before the patch it now creates the blank file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added support for KDE Plasma in a similar way as in #2 . But I'm still creating this pull request, as I fixed the issue mentioned in the said pull request, where the script would set the wallpaper only once.
I was able to find that KDE probably caches the wallpaper, so when the script downloads new and sets it, KDE ignores it or uses a cached one. I was able to get rid of this by creating a blank file, setting it as wallpaper temporarily and then setting the new wallpaper.
I also deleted the build directory, as it should be in .gitignore IMO.
Hope this works for you as well.