Skip to content

Conversation

@ruuda
Copy link
Contributor

@ruuda ruuda commented Aug 12, 2022

Let’s make a new release with the few small bugfixes for the maintainer.

@ruuda ruuda requested a review from enriquefynn August 12, 2022 11:14
@ruuda
Copy link
Contributor Author

ruuda commented Sep 27, 2022

@enriquefynn, I now also included @kkonevets changes to handle the error that the maintainer is running into, let’s make a new release and deploy this today, can you take a look?

Copy link
Member

@enriquefynn enriquefynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need to do another version to include changes from #583 or we could try to include them here

@ruuda
Copy link
Contributor Author

ruuda commented Sep 27, 2022

we need to do another version to include changes from #583

Ah yes, good point. I will cherry-pick it onto current and include it in the changelog.

@kkonevets
Copy link
Contributor

kkonevets commented Sep 27, 2022

@ruuda this commit is not valid, don't cherry pick it please. Take a look here

@ruuda
Copy link
Contributor Author

ruuda commented Sep 27, 2022

Okay, I reverted back to e83ce9bf, the deactivation is not going to happen in the very near future either way, let’s get the current fixes deployed before the end of the epoch.

@ruuda ruuda merged commit e83ce9b into current Sep 27, 2022
@ruuda ruuda deleted the release branch September 27, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants