Skip to content

Implement G3 node #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
albertna wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Implement G3 node #56

albertna wants to merge 9 commits into from

Conversation

@albertna
Copy link

@albertna albertna commented Aug 30, 2023 •
edited
Loading

Not yet tested.

  • Create sample JSON configs.

@albertna albertna marked this pull request as ready for review October 6, 2023 19:01
@albertna
Copy link
Author

albertna commented Oct 6, 2023

A few problems remain:

  • self.save_video() would success, but the preview CV2 window doesn't show up. It did show up when I used RTSP streams. I made no modifications to the config JSON file or code that adds frame data to the returned DataChunk.
  • Glasses3.rudimentary.calibrate() and Glass3.calibrate.run() are two separate calibration endpoints. I suspect the two have separate impacts, the former on rudimentary streams, and the latter on RTSP streams and on-device recordings. Can't be sure without a test.

One other thing, do we want to upgrade the Glasses3 firmware to latest? Looks like Tobii added support for targetless calibration in one of their newer firmwares (1.33 I think, latest is 1.36 and we are on 1.29).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@albertna