-
Notifications
You must be signed in to change notification settings - Fork 34
Implemented lfs for all image png, jpeg, and jpg files resolving #62 #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| 5. A minimum of two other team members will review the Pull Request and provide discussion and/or constructive feedback. Engage in communication within the Issue comments. | ||
| 6. If at least two other team members have reviewed and approved the Pull Request, it will be merged into the `main` branch using **Rebase and Merge**, unless the commits are too granular (according to the concensus of the reviewers) in which case **Squash and Merge** will summarize the commits into a single commit. | ||
| 7. Once the Pull Request has been accepted and merged, the feature branch should be deleted from the repository | ||
| 3. Ensure that all large files, including all images are tracked using Git LFS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the command needed for Git LFS here please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this is the place to add specifics commands as no other requires include commands to accomplish them. I added the commands needed to pull the repo into README and believe that should be sufficient.
reembot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ysiddhapura
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good to Me
No description provided.