-
Notifications
You must be signed in to change notification settings - Fork 25
Add grey fill in most of the charts #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grey fill in most of the charts #265
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@FedericoTartarini We have finshed all tasks and passed the tests. Please review it. |
|
@LeoLuosifen great work. However, I found the following issue
|
|
@LeoLuosifen the new code is great but there are so many repetitions, can we try to avoid repetitions, if possible otherwise the code is going to be very hard to maintain. |
|
Dear @federico and @LeoLuosifen<https://github.com/LeoLuosifen> , thanks for all the great changes!
If I can interject here, I would suggest that the grey out feature should not be part of the bar charts (i.e. Cloud cover and UTCI). They should simply show the summary statistics with the filtered data.
Best,
Giovanni
Message ID: ***@***.***>
|
- fixed the yearly chart breaking - fixed the legend color - removed the grey fill in Cloud coverage, Psychrometric Chart, and the UTCI chart - extracted the grey fill function
|
@FedericoTartarini @giobetti Thanks for your review and suggestions. I've already tried to resolve the issues mentioned above. |
514a2a2
into
CenterForTheBuiltEnvironment:development
|
@LeoLuosifen amazing work. I have reviewed the changes and I am happy with the code. I am going to publish a new test version. I also discovered how to run the tests in parallel locally, but it does not work in the github action |





No description provided.