Skip to content

Conversation

@LeoLuosifen
Copy link
Contributor

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Nov 6, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ziqi0067
Copy link
Contributor

ziqi0067 commented Nov 6, 2025

@FedericoTartarini We have finshed all tasks and passed the tests. Please review it.

@FedericoTartarini
Copy link
Contributor

FedericoTartarini commented Nov 6, 2025

@LeoLuosifen great work. However, I found the following issue

  1. chart breaking - please fix it
image
  1. wrong legend colors - please fix it
image
  1. strange layout - I am not sure what to suggest here and in the UTCI chart since they are hard to interpret when we filter by hour. Perhaps we cannot implement the gray out feature here
image
  1. dots are shown - when they should not be - avoid implementing the gray out feature here
image
  1. strage behaviour - see comment 4
image

@FedericoTartarini
Copy link
Contributor

@LeoLuosifen the new code is great but there are so many repetitions, can we try to avoid repetitions, if possible otherwise the code is going to be very hard to maintain.

@giobetti
Copy link
Contributor

giobetti commented Nov 6, 2025 via email

- fixed the yearly chart breaking
- fixed the legend color
- removed the grey fill in Cloud coverage, Psychrometric Chart, and the UTCI chart
- extracted the grey fill function
@LeoLuosifen
Copy link
Contributor Author

@FedericoTartarini @giobetti Thanks for your review and suggestions. I've already tried to resolve the issues mentioned above.

@FedericoTartarini FedericoTartarini merged commit 514a2a2 into CenterForTheBuiltEnvironment:development Nov 7, 2025
2 checks passed
@FedericoTartarini
Copy link
Contributor

@LeoLuosifen amazing work. I have reviewed the changes and I am happy with the code. I am going to publish a new test version. I also discovered how to run the tests in parallel locally, but it does not work in the github action pipenv run pytest --base-url=http://127.0.0.1:8080 -vv --numprocesses 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants