[ENG-10071] Feature/optimize subscription population script #11560
+248
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
reviewed
Jan 20, 2026
| ) | ||
| total_created += len(items_to_create) | ||
|
|
||
| print(f"Created {total_created} subscriptions.") |
Collaborator
There was a problem hiding this comment.
Let's add a timing to track how long it takes, for each batch and/or for the total.
cslzchen
reviewed
Jan 21, 2026
| total_created = 0 | ||
|
|
||
| for count, user in enumerate(user_qs, 1): | ||
| batch_start = datetime.now() |
Collaborator
There was a problem hiding this comment.
Move batch_start out of the for loop and reset it after each batch process.
| print(f'Error during bulk_create: {e}') | ||
| finally: | ||
| items_to_create.clear() | ||
| batch_end = datetime.now() |
Collaborator
There was a problem hiding this comment.
Similarly, batch_end should be inside the if block for processing each batch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Optimize subscription population scripts
Changes
Optimize subscription population scripts
Side Effects
TBD
QE Notes
TBD
CE Notes
TBD
Documentation
TBD