Skip to content

Conversation

@Ostap-Zherebetskyi
Copy link
Collaborator

Ticket

https://openscience.atlassian.net/browse/ENG-10083

Purpose

Add type and is_digest "relation" and update subscription

Changes

Side Effects

QE Notes

CE Notes

Documentation

@Ostap-Zherebetskyi Ostap-Zherebetskyi marked this pull request as ready for review January 20, 2026 12:35
@bodintsov
Copy link
Contributor

LGTM!

Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to re-order the types and add comments.

Update: let's also add a sanity check in emit() to make sure the is_digest param matches the type's is_digest.

Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few questions on the unit test fixes. Let's take a look together tomorrow.

@cslzchen cslzchen merged commit ced4078 into CenterForOpenScience:feature/notifications-refactor-post-release Jan 21, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants