-
Notifications
You must be signed in to change notification settings - Fork 355
[ENG-10083] Add type and is_digest "relation" and update subscription #11558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-10083] Add type and is_digest "relation" and update subscription #11558
Conversation
|
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need to re-order the types and add comments.
Update: let's also add a sanity check in emit() to make sure the is_digest param matches the type's is_digest.
cslzchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
cslzchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a few questions on the unit test fixes. Let's take a look together tomorrow.
ced4078
into
CenterForOpenScience:feature/notifications-refactor-post-release
Ticket
https://openscience.atlassian.net/browse/ENG-10083
Purpose
Add type and is_digest "relation" and update subscription
Changes
Side Effects
QE Notes
CE Notes
Documentation