-
Notifications
You must be signed in to change notification settings - Fork 355
[ENG-10080] Create global_file_updated, global_reviews and node_file_updated subscriptions if missing #11556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cslzchen
wants to merge
8
commits into
CenterForOpenScience:feature/notifications-refactor-post-release
Choose a base branch
from
cslzchen:feature/create-missing-subscriptions-otf
base: feature/notifications-refactor-post-release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use USER_FILE_UPDATED for group global_file_updated * Use REVIEWS_SUBMISSION_STATUS for group global_reviews
Ostap-Zherebetskyi
approved these changes
Jan 20, 2026
Collaborator
Ostap-Zherebetskyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎆
cslzchen
commented
Jan 20, 2026
api/subscriptions/views.py
Outdated
| ), | ||
| ) | ||
| existing_subscriptions = annotated_obj_qs.filter(legacy_id=subscription_id) | ||
| if not existing_subscriptions: |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| if not existing_subscriptions: | |
| if not existing_subscriptions.exists(): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Create global_file_updated, global_reviews and node_files_updated subscriptions if missing
USER_FILE_UPDATEDfor group_global_file_updatedREVIEWS_SUBMISSION_STATUSfor group_global_reviewsNODE_FILE_UPDATEDfor group_node_file_updatedIn addtion,
_is_digest=Truefor newly created OSF users's default subscriptionsannotated_obj_qsforNODE_FILE_UPDATEDnode_file_updatedsubscription detailChanges
See dfif
Side Effects
N/A
QE Notes
N/A
CE Notes
N/A
Documentation
N/A