Skip to content

Conversation

@cslzchen
Copy link
Collaborator

@cslzchen cslzchen commented Jan 19, 2026

Ticket

Purpose

Create global_file_updated, global_reviews and node_files_updated subscriptions if missing

  • Use USER_FILE_UPDATED for group _global_file_updated
  • Use REVIEWS_SUBMISSION_STATUS for group _global_reviews
  • Use NODE_FILE_UPDATED for group _node_file_updated

In addtion,

  • Added _is_digest=True for newly created OSF users's default subscriptions
  • Enforce and improve permission check for subscriptions
  • Fix typo in annotated_obj_qs for NODE_FILE_UPDATED
  • Add unit tests for testing node_file_updated subscription detail

Changes

See dfif

Side Effects

N/A

QE Notes

N/A

CE Notes

N/A

Documentation

N/A

Copy link
Collaborator

@Ostap-Zherebetskyi Ostap-Zherebetskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎆

@cslzchen cslzchen changed the title [ENG-10080] Create global_file_updated and global_reviews subscriptions if missing [ENG-10080] Create global_file_updated, global_reviews and node_files_updated subscriptions if missing Jan 20, 2026
),
)
existing_subscriptions = annotated_obj_qs.filter(legacy_id=subscription_id)
if not existing_subscriptions:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if not existing_subscriptions:
if not existing_subscriptions.exists():

@cslzchen cslzchen changed the title [ENG-10080] Create global_file_updated, global_reviews and node_files_updated subscriptions if missing [ENG-10080] Create global_file_updated, global_reviews and node_file_updated subscriptions if missing Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants