Added IsFinished, LogInfo and ClearOnFinish #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a boolean flag to enable Log.Info messages in the code. * Added a boolean flag to track whether the song has finished playing. * Added a boolean flag to determine whether, upon finishing the track, the component and the referenceHub should be destroyed. * Documented and improved PlayerIsConnected check to determine if the player is a DummyPlayer, as it's unnecessary to send audio packets to them. * Added Visual Studio and Rider related build files to .gitignore.
Author
|
@ced777ric PING. you're not going to ignore me for 3 months like #6 |
Member
#6 was not ignored, it has conflicts and requested changes. |
Author
|
Member
|
|
ced777ric
requested changes
Apr 5, 2024
| hub.nicknameSync.NickSet && | ||
| !hub.isLocalPlayer && | ||
| !string.IsNullOrEmpty(hub.authManager.UserId) && | ||
| hub.authManager.UserId != null && |
Member
There was a problem hiding this comment.
The userid is checked for being null checked twice, once by IsNullOrEmpty and the second time with a null check.
ced777ric
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a boolean flag to enable Log.Info messages in the code.
Added a boolean flag to track whether the song has finished playing.
Added a boolean flag to determine whether, upon finishing the track, the component and the referenceHub should be destroyed.
Documented and improved PlayerIsConnected check to determine if the player is a DummyPlayer, as it's unnecessary to send audio packets to them.
Added Visual Studio and Rider related build files to .gitignore.