Sd 106 update metadata #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rAskVAL
changed the base branch from
blanksquare-rebranding
to
SD-106-rebranding
rAskVAL
force-pushed
the
SD-106-rebranding
branch
from
23317d1 to
a8f2555
Compare
jalooc
approved these changes
Jul 15, 2025
Contributor
jalooc
left a comment
jalooc
left a comment
There was a problem hiding this comment.
You should revert absolute imports paths almost everywhere where you changed src/domains/... to '../../../'. Other than that lgtm.
.idea/workspace.xml
Outdated
| import { typography } from 'src/domains/styling/utils/tokens'; | ||
| import vars from 'src/domains/styling/utils/vars'; | ||
|
|
||
| import BIcon from '../../misc/components/BIcon'; |
Contributor
There was a problem hiding this comment.
Suggested change
| import BIcon from '../../misc/components/BIcon'; | |
| import BIcon from 'src/misc/components/BIcon'; |
here and everywhere else.
Contributor
|
Btw I wouldn't call these things metadata. It's tokens and icons, so regular data; or rather not data at all: just tokens and icons ;P |
rAskVAL
force-pushed
the
SD-106-update-metadata
branch
2 times, most recently
from
f981c00 to
db1a2f9
Compare
rAskVAL
force-pushed
the
SD-106-update-metadata
branch
from
db1a2f9 to
fc0e186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.