Fix error when exporting failure with '<' sign.#18
Open
jorenblancquaert wants to merge 1 commit intoCameronWills:masterfrom
Open
Fix error when exporting failure with '<' sign.#18jorenblancquaert wants to merge 1 commit intoCameronWills:masterfrom
jorenblancquaert wants to merge 1 commit intoCameronWills:masterfrom
Conversation
Collaborator
|
Thank you for the pull request @jorenblancquaert. Looking through your code, I can see that you are targeting just the one character to replace. I suspect that we may need to replace other characters as well, and it might be worthwhile if we investigate the inbuilt functionality of the OpenEdge XML writers for this. At the same time, I suspect that you may have found a bug that is present in some of the other output formats (specifically the JUnit formatter) and so it makes sense to check here as well. At the moment, I can't confirm the details I mentioned above, but will leave the request open until I can (unless anyone else is able to investigate as well) Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reporting a failure with SureFireReporter, the class gave an progress exception because the exporting of the less than sign ('<') is not supported.
We can replace this character by '<', this fixed the problem, and does export a proper xml.
The progress error :
4GL 4GLTRACE Return from RunClassAsTest [OEUnit/Automation/Pct/RunTests] ERROR 4GL -- (Procedure: 'OEUnit/Automation/Pct/RunTests' Line:41) X-NODEREF or X-DOCUMENT LOAD got an error: FATAL ERROR: file 'MEMPTR', line '3', column '0', message ''<' character cannot be used in attribute value 'message'; use < instead'. (9082) 4GL 4GLTRACE Run RunClassAsTest "C:\workspace\Samplenet\samplenet_12_pro\samplenet-abl-sources\test\be\mips\samplenet\manual\samplelog\TestSampleLogFinder.cls" [Main Block - OEUnit/Automation/Pct/RunTests @ 41]See attached screenshot of OEUnit in eclipse which can not be exported with the SureFireReporter.