Avoid asking user to use template if templateName exists#77
Open
troym9731 wants to merge 2 commits intoCVarisco:masterfrom
Open
Avoid asking user to use template if templateName exists#77troym9731 wants to merge 2 commits intoCVarisco:masterfrom
templateName exists#77troym9731 wants to merge 2 commits intoCVarisco:masterfrom
Conversation
CVarisco
reviewed
Nov 20, 2018
|
|
||
| async function getTemplateOption() { | ||
| const templateArg = args.t || args.template | ||
| const templateArg = config.t || config.template || config.templateName |
Owner
There was a problem hiding this comment.
Thank you for your catch!
This line is ok ;)
CVarisco
reviewed
Nov 20, 2018
| return getTemplatesPath(templateArg) | ||
| } | ||
|
|
||
| const { template } = await inquirer.prompt([ |
Owner
There was a problem hiding this comment.
These lines of code need in case the template is not specified in the config.
The behavior is expected because one of the features of the tool is to use templates from the community.
Could you please commit again with these lines of code?
Thank you so much man for your contribution 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even when specifying a
templateNamein a config file, the "Do you wanna choose a template" prompt comes up.It seems like now that the config object is a combination of both the args and the config passed by the user, it should be fine to get rid of this prompt and just check for the existence of
config.t,config.template, orconfig.templateName.