FindInLEV #239
Open
FindInLEV #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheUbMunster
commented
Jan 8, 2026
| for (int i = 0; i < levTexLookup->numIconGroup; i++) | ||
| { | ||
| struct IconGroup* iconGroupPtr = levTexLookup->firstIconGroupPtr[i]; | ||
| if (((*(int*)(iconGroupPtr->name + 0)) == (*(int*)(str + 0))) && |
Contributor
Author
There was a problem hiding this comment.
"efficient string comparison", the same way ND did it. do we have memcmp? (strcmp wouldn't behave the same because memcmp will check beyond the nullterm (like original impl), but strcmp won't).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd love to test, but for some reason it won't build because of some problem in the UI namespace